From 0fe8ce53ac64397d192fd22c54c203c06dd1a658 Mon Sep 17 00:00:00 2001
From: justin <justin@liquidator.optimal-reality.com>
Date: Tue, 2 Jun 2026 13:12:40 -0500
Subject: [PATCH] intake: guard hoisted step scripts against absent DOM

Astro hoists multiple step scripts from Wizard even when the step is not
rendered on the current order page. Several steps bound DOM elements at load
time with no presence check, causing null addEventListener errors on unrelated
order pages.

Add step-presence guards to the obvious offenders used by the shared wizard:
IccImportStep, Block6CertStep, WirelessStep, BundledServiceStep, CPNIStep,
and LNPARegionStep.
---
 site/src/components/intake/steps/Block6CertStep.astro     | 2 ++
 site/src/components/intake/steps/BundledServiceStep.astro | 2 ++
 site/src/components/intake/steps/CPNIStep.astro           | 2 ++
 site/src/components/intake/steps/IccImportStep.astro      | 2 ++
 site/src/components/intake/steps/LNPARegionStep.astro     | 2 ++
 site/src/components/intake/steps/WirelessStep.astro       | 2 ++
 6 files changed, 12 insertions(+)

diff --git a/site/src/components/intake/steps/Block6CertStep.astro b/site/src/components/intake/steps/Block6CertStep.astro
index 8826315..655a93e 100644
--- a/site/src/components/intake/steps/Block6CertStep.astro
+++ b/site/src/components/intake/steps/Block6CertStep.astro
@@ -110,6 +110,7 @@ import DeMinimisChoiceExplainer from "../DeMinimisChoiceExplainer.astro";
 <script>
   import { NONDISCLOSURE_CERT_TEXT } from "../../../lib/fcc_constants";
 
+  if (document.querySelector('[data-slug="block6_cert"], [data-step="block6_cert"]')) {
   const exUsf = document.getElementById("pw-ex-usf") as HTMLInputElement;
   const exTrs = document.getElementById("pw-ex-trs") as HTMLInputElement;
   const exNanpa = document.getElementById("pw-ex-nanpa") as HTMLInputElement;
@@ -239,4 +240,5 @@ import DeMinimisChoiceExplainer from "../DeMinimisChoiceExplainer.astro";
       waive_deminimis_reason: election === "regular" ? (waiveReason.value.trim() || null) : null,
     });
   });
+  }
 </script>
diff --git a/site/src/components/intake/steps/BundledServiceStep.astro b/site/src/components/intake/steps/BundledServiceStep.astro
index 0bf3ce5..74bc0ea 100644
--- a/site/src/components/intake/steps/BundledServiceStep.astro
+++ b/site/src/components/intake/steps/BundledServiceStep.astro
@@ -47,6 +47,7 @@
 </style>
 
 <script>
+  if (document.querySelector('[data-slug="bundled_service"], [data-step="bundled_service"]')) {
   const hasBundle = document.getElementById("pw-bs-has-bundle") as HTMLInputElement;
   const details = document.getElementById("pw-bs-details") as HTMLElement;
   const bundleRev = document.getElementById("pw-bs-bundle-rev") as HTMLInputElement;
@@ -95,4 +96,5 @@
       } : { has_bundle: false },
     });
   });
+  }
 </script>
diff --git a/site/src/components/intake/steps/CPNIStep.astro b/site/src/components/intake/steps/CPNIStep.astro
index 523b4be..ea60cec 100644
--- a/site/src/components/intake/steps/CPNIStep.astro
+++ b/site/src/components/intake/steps/CPNIStep.astro
@@ -96,6 +96,7 @@
 </style>
 
 <script>
+  if (document.querySelector('[data-slug="cpni_questions"], [data-step="cpni_questions"]')) {
   const yearEl = document.getElementById("pw-cpni-year")!;
   const reportingYear = new Date().getFullYear() - 1;
   yearEl.textContent = String(reportingYear);
@@ -165,4 +166,5 @@
       });
     }
   });
+  }
 </script>
diff --git a/site/src/components/intake/steps/IccImportStep.astro b/site/src/components/intake/steps/IccImportStep.astro
index e638b47..b98087e 100644
--- a/site/src/components/intake/steps/IccImportStep.astro
+++ b/site/src/components/intake/steps/IccImportStep.astro
@@ -72,6 +72,7 @@
 </style>
 
 <script>
+  if (document.querySelector('[data-slug="icc_import"], [data-step="icc_import"]')) {
   const drop = document.getElementById("pw-icc-drop") as HTMLElement;
   const fileInput = document.getElementById("pw-icc-file") as HTMLInputElement;
   const browse = document.getElementById("pw-icc-browse") as HTMLButtonElement;
@@ -194,4 +195,5 @@
       icc_revenue_source: confirmCb.checked ? "imported" : null,
     });
   });
+  }
 </script>
diff --git a/site/src/components/intake/steps/LNPARegionStep.astro b/site/src/components/intake/steps/LNPARegionStep.astro
index 96d3d1d..2bca295 100644
--- a/site/src/components/intake/steps/LNPARegionStep.astro
+++ b/site/src/components/intake/steps/LNPARegionStep.astro
@@ -61,6 +61,7 @@ import { LNPA_REGIONS } from "../../../lib/lnpa_regions_catalog";
 <script>
   import { LNPA_REGIONS } from "../../../lib/lnpa_regions_catalog";
 
+  if (document.querySelector('[data-slug="lnpa_region"], [data-step="lnpa_region"]')) {
   const body = document.getElementById("pw-lnpa-body")!;
   const b3Sum = document.getElementById("pw-lnpa-b3-sum")!;
   const b4Sum = document.getElementById("pw-lnpa-b4-sum")!;
@@ -173,4 +174,5 @@ import { LNPA_REGIONS } from "../../../lib/lnpa_regions_catalog";
       }).catch(() => {});
     }
   });
+  }
 </script>
diff --git a/site/src/components/intake/steps/WirelessStep.astro b/site/src/components/intake/steps/WirelessStep.astro
index a776483..8687873 100644
--- a/site/src/components/intake/steps/WirelessStep.astro
+++ b/site/src/components/intake/steps/WirelessStep.astro
@@ -62,6 +62,7 @@
 </style>
 
 <script>
+  if (document.querySelector('[data-slug="wireless"], [data-step="wireless"]')) {
   const infra = document.getElementById("pw-wl-infra") as HTMLSelectElement;
   const mvnoWrap = document.getElementById("pw-wl-mvno-wrap") as HTMLElement;
   const facWrap = document.getElementById("pw-wl-fac-wrap") as HTMLElement;
@@ -109,4 +110,5 @@
     };
     PW.patchIntakeData({ wireless_meta: meta });
   });
+  }
 </script>