justin/new-site
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(formation): name-search returns null (not false) on adapter error

Browse source 
E2E harness exposed that the NV name-search adapter times out on a stale input
selector and search_name() swallowed the error and returned available=False --
i.e. it would tell customers an AVAILABLE name is taken. Now returns
available=None ('could not determine') on adapter error / unknown state, which the
API already maps to null. The NV/TX portal selectors still need a scraping fix
(separate task; e2e harness is the acceptance test) before enabling a self-serve
formation checkout. Documented full e2e results + the bugs caught (missing ERPNext
Items, entity_type case, missing /name-search route) in the readiness doc.
This commit is contained in:
justin 2026-06-09 08:06:43 -05:00
parent 4c0decd175
commit 76c4d55603
3 changed files with 53 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/formation/base.py
View file

@ -68,7 +68,7 @@ class FilingStatus(str, Enum):
@dataclass
class NameSearchResult:
available: bool
available: bool | None # True/False, or None when the lookup could not be completed (adapter error)
exact_match: bool = False
similar_names: list[str] = field(default_factory=list)
state_code: str = ""